Refactor (Core): Move from scoped variables to node built-in AsyncLocalStorage #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBoudrias
force-pushed
the
async-storage-hooks
branch
from
22a930e
to
ef20529
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1285 +/- ##
==========================================
+ Coverage 77.00% 77.23% +0.23%
==========================================
Files 41 41
Lines 4127 4134 +7
Branches 729 722 -7
==========================================
+ Hits 3178 3193 +15
+ Misses 229 227 -2
+ Partials 720 714 -6
☔ View full report in Codecov by Sentry. |
SBoudrias
force-pushed
the
async-storage-hooks
branch
from
ef20529
to
739fc5e
Compare
SBoudrias
commented
Aug 19, 2023
| @@ -381,23 +381,6 @@ describe('Error handling', () => { | |||
| await expect(answer).rejects.toThrowError('Error in render function'); | |||
| }); | |||
|
|
|||
| it('Prevent trying to run 2 prompts at once.', async () => { | |||
There was a problem hiding this comment.
Side effect, it becomes theoretically possible to run 2 inquirer prompts at once.
This is unlikely to have much benefits but:
- Could be theoretically possible to run prompts on different streams (if Node Readline allow it - it used to have singleton conflicts)
- When running tests today, if a test fail Inquirer doesn't cleanup. This won't happen anymore 🎉
SBoudrias
force-pushed
the
async-storage-hooks
branch
from
ba8b8a2
to
bcedd26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: State management through the scoped variables did (and could again, or might still do so in narrow cases) cause leaks in context around async operations and cleanup phases. I think using AsyncLocalStorage might improve this caveats by ensuring a stable context.