Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DataDictionarySource import #45

Merged
merged 7 commits into from
Oct 23, 2024
Merged

Add DataDictionarySource import #45

merged 7 commits into from
Oct 23, 2024

Conversation

mehmetcanay
Copy link
Member

@mehmetcanay mehmetcanay commented Oct 23, 2024 •
edited
Loading

  • Removed object return type due to Pylance warnings
  • Added Optional type where None is the default value of a parameter
  • Added import_data_dictionary function for SQL and Weaviate repositories to allow the import of DataDictionarySource
  • Implemented the tests for the new function

closes #25

@mehmetcanay mehmetcanay added the enhancement New feature or request label Oct 23, 2024
@mehmetcanay mehmetcanay requested a review from tiadams October 23, 2024 10:42
@mehmetcanay mehmetcanay self-assigned this Oct 23, 2024
tiadams
tiadams reviewed Oct 23, 2024
View reviewed changes
tests/test_sql_repository.py Outdated Show resolved Hide resolved
tests/test_weaviate_repository.py Show resolved Hide resolved
tiadams
tiadams reviewed Oct 23, 2024
View reviewed changes
datastew/repository/sqllite.py Outdated Show resolved Hide resolved
datastew/repository/weaviate.py Outdated Show resolved Hide resolved
tests/test_sql_repository.py Show resolved Hide resolved
@tiadams tiadams merged commit 6f38a7e into main Oct 23, 2024
4 checks passed
@tiadams tiadams deleted the add-datadictionary-import branch October 23, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiadams tiadams tiadams left review comments

Assignees

@mehmetcanay mehmetcanay

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datadictionary Repository import
2 participants
@mehmetcanay @tiadams