Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carthage build fails when using XCFrameworks flag #56

Open
daltonclaybrook opened this issue May 6, 2021 · 3 comments
Open

Carthage build fails when using XCFrameworks flag #56

daltonclaybrook opened this issue May 6, 2021 · 3 comments

Comments

@daltonclaybrook
Copy link
Contributor

Attempting to build SDWebImageWebPCode with Carthage using the --use-xcframeworks flag results in a build failure. The following error is observed in the log:

...SDImageWebPCoder.h:12:9: fatal error: module 'SDWebImage' not found
@import SDWebImage;
 ~~~~~~~^~~~~~~~~~
1 error generated.

The issue appears to be caused by incomplete FRAMEWORK_SEARCH_PATHS for SDWebImageWebPCoder. Presently, this build setting includes the platform-specific build folder (e.g. $(PROJECT_DIR)/Carthage/Build/iOS) but does not include the root build folder ($(PROJECT_DIR)/Carthage/Build), which is where XCFrameworks are located.

@dreampiggy
Copy link
Contributor

dreampiggy commented May 6, 2021

That #57 merged. I'll release a patch version 0.8.4

However, is this only thing to do that support Carthage with XCFramework ?

I remember the issue talked here: Carthage/Carthage#3019 (comment)

Carthage need all the downstream component, to update their Xcode and create a new scheme "Like SDWebImage XCFramework" and add dependency to that.

@daltonclaybrook
Copy link
Contributor Author

This is not the case in my experience. For example, SDWebImage and other dependencies build fine as XCFrameworks already.

SDWebImageWebPCoder build console

@dreampiggy
Copy link
Contributor

Looks great. If Carthage's XCFramework adoptation does not cost too much of maintainess issues, I can update all SDWebImage related components together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants