-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carthage build fails when using XCFrameworks flag #56
Comments
That #57 merged. I'll release a patch version 0.8.4 However, is this only thing to do that support Carthage with XCFramework ? I remember the issue talked here: Carthage/Carthage#3019 (comment) Carthage need all the downstream component, to update their Xcode and create a new scheme "Like SDWebImage XCFramework" and add dependency to that. |
Looks great. If Carthage's XCFramework adoptation does not cost too much of maintainess issues, I can update all SDWebImage related components together. |
Attempting to build SDWebImageWebPCode with Carthage using the
--use-xcframeworks
flag results in a build failure. The following error is observed in the log:The issue appears to be caused by incomplete
FRAMEWORK_SEARCH_PATHS
for SDWebImageWebPCoder. Presently, this build setting includes the platform-specific build folder (e.g.$(PROJECT_DIR)/Carthage/Build/iOS
) but does not include the root build folder ($(PROJECT_DIR)/Carthage/Build
), which is where XCFrameworks are located.The text was updated successfully, but these errors were encountered: