From cf580010162cc4d422192951c9e0b05c74c7be7b Mon Sep 17 00:00:00 2001 From: Felix Schlegel Date: Tue, 17 Dec 2024 12:12:01 +0100 Subject: [PATCH] ci: replace hard coded env variable with variable from github This way, we can control the value at one place --- .github/workflows/build.yml | 2 +- .github/workflows/code_quality_checks.yml | 2 +- .github/workflows/lighthouse.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 21edee2..5ca7581 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -9,7 +9,7 @@ on: env: node_version: ${{ vars.NODE_VERSION }} - PUBLIC_API_BASE_URL: http://localhost:8080 + PUBLIC_API_BASE_URL: ${{ vars.PUBLIC_API_BASE_URL }} jobs: build: diff --git a/.github/workflows/code_quality_checks.yml b/.github/workflows/code_quality_checks.yml index 8b6d439..bd39ddd 100644 --- a/.github/workflows/code_quality_checks.yml +++ b/.github/workflows/code_quality_checks.yml @@ -10,7 +10,7 @@ on: env: node_version: ${{ vars.NODE_VERSION }} - PUBLIC_API_BASE_URL: http://localhost:8080 + PUBLIC_API_BASE_URL: ${{ vars.PUBLIC_API_BASE_URL }} jobs: linting: diff --git a/.github/workflows/lighthouse.yml b/.github/workflows/lighthouse.yml index 8311e3b..346403a 100644 --- a/.github/workflows/lighthouse.yml +++ b/.github/workflows/lighthouse.yml @@ -7,7 +7,7 @@ on: env: node_version: ${{ vars.NODE_VERSION }} - PUBLIC_API_BASE_URL: http://localhost:8080 + PUBLIC_API_BASE_URL: ${{ vars.PUBLIC_API_BASE_URL }} jobs: lighthouse: