Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error on engine modpack load #1574

Closed
wants to merge 6 commits into from
Closed

Fix error on engine modpack load #1574

wants to merge 6 commits into from

Conversation

heinezen
Copy link
Member

Resolves #1569

@heinezen heinezen added area: simulation Involved in the game mechanics and simulation bugfix Restores intended behavior labels Oct 10, 2023
@heinezen heinezen mentioned this pull request Oct 10, 2023
Closed
TheJJ
TheJJ reviewed Oct 12, 2023
View reviewed changes
openage/convert/service/init/api_export_required.py
@@ -16,7 +16,7 @@
from openage.util.fslike.union import UnionPath


CURRENT_API_VERSION = "0.4.0"
CURRENT_API_VERSION = "0.5.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should import the global version id here, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was more of a test because I thought the API modpack might have been wrongly generated and caused the error in #1569 . But this was probably not the issue.

I don't think the modpack version should be bumped with every engine release btw. but maybe if there's a new version of the engine modpack, it should have the same version no as the current engine version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i might close this PR and think of something else to fix the issue

openage/convert/tool/api_export.py
@@ -76,7 +76,7 @@ def create_modpack() -> Modpack:

mod_def = modpack.get_info()

mod_def.set_info("engine", "0.4.0", repo="openage")
mod_def.set_info("engine", "0.5.1", versionstr="0.4.0", repo="openage")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well. should be a single source of truth?

@heinezen heinezen mentioned this pull request Oct 15, 2023
Merged
@heinezen
Copy link
Member Author

Supreceded by #1574

@heinezen heinezen closed this Oct 15, 2023
@heinezen heinezen deleted the fix/modpack-load branch November 15, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJJ TheJJ TheJJ left review comments

Assignees
No one assigned
Labels
area: simulation Involved in the game mechanics and simulation bugfix Restores intended behavior
Projects
openage game simulation
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error launching game, uncaught exception(s)
2 participants
@heinezen @TheJJ