Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for RFC5549 #72

Open
ayalaalex opened this issue Jun 13, 2018 · 2 comments
Open

Support for RFC5549 #72

ayalaalex opened this issue Jun 13, 2018 · 2 comments
Labels

Comments

@ayalaalex
Copy link

Advertising IPV4 networks with IPV6 NH
https://tools.ietf.org/html/rfc5549

Right now if the Prefix is IPV4 openBMP will convert NH to IPV4 format, otherwise use IPV6 format.

if (nlri.nh_len > 16)
memcpy(ip_raw, nlri.next_hop, 16);
else
memcpy(ip_raw, nlri.next_hop, nlri.nh_len);

inet_ntop(isIPv4 ? AF_INET : AF_INET6, ip_raw, ip_char, sizeof(ip_char));

@ayalaalex
Copy link
Author

VPNV6 prefixes have similar issues:
u*>i 10.20.1.132:1:3ffe::4207:100/120 100 None
::ffff:10.20.1.131 38271 524280

Gets stored as prefix with NH :: instead of ::ffff:10.20.1.131 also the path_id it sets it to 0 instead of 38271.

@TimEvens
Copy link
Contributor

Thanks for the details. Will fix this in the coming weeks. There are some collector updates that need to be done.

@TimEvens TimEvens added the bug label Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants