Add support for Network address types for PostgreSQL #1078
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I've somehow missed this. I see no problem with applying this, but I wonder if we should add support for the other related types too, see ? |
|
Hello, sorry for the late answer, I was a bit busy and sick. I will look into this and add it, it looks easy and unless I am mistaken there are just 2 more types to add. I will update the pull request probably over weekend. |
|
@Liewyec do you still plan to do it? TIA! |
|
Hello, yes I am planing to do this, I should have a bit less work in next few weeks. Sorry it takes so long a I had a lot of other work. |
Liewyec
force-pushed
the
ip-mac-support
branch
from
5408cdd
to
51c0ba4
Compare
|
Hello, I added the two more types, sorry it was taking so long. |
|
Thanks, will merge soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed a missing support for Network address types for PostgreSQL. I added the support and they are returned s strings.