Skip to content
This repository has been archived by the owner on Feb 16, 2024. It is now read-only.

Documentation of utils.rs #57

Open
6 of 12 tasks
Razican opened this issue Oct 9, 2016 · 10 comments
Open
6 of 12 tasks

Documentation of utils.rs #57

Razican opened this issue Oct 9, 2016 · 10 comments

Comments

@Razican
Copy link
Member

Razican commented Oct 9, 2016

Most of the code is still not documented. This is the tracking issue for utils.rs file documentation.

  • Module level documentation.
  • PARSER_CONFIG constant.
  • print_error() function.
  • print_warning() function.
  • print_vulnerability() function.
  • get_code() function.
  • get_string() function:
    • Function level documentation.
    • Inline comments.
  • Tests:
    • it_get_code() function.
    • it_file_exists() function.
@iamdharmveer
Copy link

I can do this for you 👍

@Razican
Copy link
Member Author

Razican commented Oct 9, 2016

@iamdharmveer wow! great, thanks!! 😃

@iamdharmveer
Copy link

Can you give me more details about the documentation 👍

@Razican
Copy link
Member Author

Razican commented Oct 9, 2016

For getters and setters, a small (even one line) explanation on the parameter they get and set would be enough. For constants, their function (in this case, PARSER_CONFIG is the parser configuration used for the XML parser).

Function descriptions should show what functions do, in this case, print_error() and print_warning() are used for errors and warnings of the analysis process itself, and they color them on stdout in different colors.

A good example of a documentation can be found in this crate.

@iamdharmveer
Copy link

All changes in documentation.md Because I didn't found utils.rs so I'm asking about which file do you want to change ?

@iamdharmveer
Copy link

Ok thank you 👍

@Razican
Copy link
Member Author

Razican commented Oct 9, 2016

Nope, files are relative to the src/ folder. So in this case, it would be the src/utils.rs file, and the documentation would need to be created using the Rust documentation format.

@iamdharmveer
Copy link

One more query if I want to join your organization how can it's happen 😄

@Razican
Copy link
Member Author

Razican commented Oct 9, 2016

Well, that is something that would happen with enough pull requests from you :) if you manage to get many pull requests merged in SUPER, you would probably become a collaborator, and after some time, a full member of the team :)

@iamdharmveer
Copy link

Thank You 😄 👍

@Razican Razican mentioned this issue Oct 9, 2016
22 tasks
@Razican Razican added this to the SUPER 0.6.0 milestone Nov 11, 2019
@Razican Razican modified the milestones: SUPER 0.6.0, SUPER 0.7.0 Mar 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants