From 66324f7b39aa1103ea3c523b48bc2461b0e80f47 Mon Sep 17 00:00:00 2001 From: Rick Salevsky Date: Mon, 1 Jul 2019 12:08:02 +0200 Subject: [PATCH 1/2] gitlint: Allow trivial changes to be without reference (SOC-9559) The author of a commit should make a conscious decision to either add a reference or not. Adding trivial instead of bsc or SOC enables this. This change prevents that adding a refernce is forgotten as the syntax requires to think about it. trivial -> simple unplanned changes noref -> more complex unplanned changes typo -> typo fixes only See https://github.com/SUSE-Cloud/automation/pull/3509#discussion_r298963183 for more details. --- scripts/jenkins/gitlint.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/jenkins/gitlint.ini b/scripts/jenkins/gitlint.ini index 8b0eeb4245..6733008d84 100644 --- a/scripts/jenkins/gitlint.ini +++ b/scripts/jenkins/gitlint.ini @@ -8,7 +8,7 @@ line-length=80 words=wip,WIP [title-match-regex] -regex=^(?!SOC).*\(((bsc#|SOC-)[0-9]+(,\s)?)+\)$ +regex=^(?!SOC).*\((((bsc#|SOC-)[0-9]+(,\s)?)+|trivial|typo|noref)\)$ [body-max-line-length] line-length=80 From 2368013f4b08af117346d2810ec0e8bfe6d4ce79 Mon Sep 17 00:00:00 2001 From: Rick Salevsky Date: Mon, 1 Jul 2019 12:14:21 +0200 Subject: [PATCH 2/2] gitlint: Remove author valid mail check (SOC-9559) This check prevented external contributions. --- scripts/jenkins/gitlint.ini | 3 --- 1 file changed, 3 deletions(-) diff --git a/scripts/jenkins/gitlint.ini b/scripts/jenkins/gitlint.ini index 6733008d84..9952843eef 100644 --- a/scripts/jenkins/gitlint.ini +++ b/scripts/jenkins/gitlint.ini @@ -15,6 +15,3 @@ line-length=80 [body-min-length] min-length=5 - -[author-valid-email] -regex=[^@]+@suse.(com|de)