-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample rename in same directory somehow got through the acquisition start checks #424
Comments
Ok, this is actually expected behavior. A renamed sample ID will pass through the checks. This is because after the sample is renamed there is no risk of writing data into existing section directories. The problem, of course, is that then the data are annoying to deal with. I think it's best to just block the user from writing into an existing section directory at all. They must always resume. |
086c7ae begins to address the issue. If a sample is marked as FINISHED then the acquisition will not proceed. Instead the user is prompted to restart or make a new sample directory. The restart will handle the FINISHED file. The user is no longer prompted to change sample ID to carry on writing into the same directory. We can probably seal the problem up by blocking a new recipe ID from being made in the first place. |
SM on BS stopped an acquisition with FINISHED checkbox checked. Then renamed sample ID and pressed Bake. The acquisition restarted numbered at 1 without raising an error message.
The text was updated successfully, but these errors were encountered: