Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pockels switches off on BakingTray startup #428

Open
raacampbell opened this issue May 24, 2022 · 1 comment
Open

Pockels switches off on BakingTray startup #428

raacampbell opened this issue May 24, 2022 · 1 comment
Labels
bug minor

Comments

@raacampbell
Copy link
Collaborator

Despite 481fbb4 the pockels switches off when BT starts even if laser is on during startup
@raacampbell
Copy link
Collaborator Author

raacampbell commented May 25, 2022 •
edited
Loading

This fixes it: 50fbb08

There was property caching power on state that was by default set to false.

Still to do:

  • Do we really need to call the Pockels switch code in the constructor? Is it enough to simply update the properties?
  • There is now a lot of redundant code in the different laser classes. How can we simplify? e.g. make a method in laser that all classes must call at the end of the constructor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raacampbell