-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IBCDPE-1095] Signoz move to lets encrypt #45
Merged
BryanFauble
merged 10 commits into
signoz-alert-manager
from
ibcdpe-1095-signoz-move-to-lets-encrypt
Nov 5, 2024
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d090f60
Point to lets encrypt staging
BryanFauble b86191f
Merge branch 'main' into signoz-move-to-lets-encrypt-staging
BryanFauble d04e529
Remove auth0_domain
BryanFauble c08c572
Point at lets encrypt prod
BryanFauble b9f9949
Remove security policy at gateway level
BryanFauble 2db7f0d
Merge branch 'signoz-move-to-lets-encrypt-staging' into ibcdpe-1095-s…
BryanFauble 2e1d511
Upgrade HTTP connections to HTTPS with a redirect
BryanFauble ce790e5
Remove the need for email domains to be set
BryanFauble 7e9ac5b
Move token lifecycle to 1.25 days from 1 day
BryanFauble 483a798
Merge branch 'signoz-alert-manager' into ibcdpe-1095-signoz-move-to-l…
BryanFauble File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,18 @@ | ||
# To implement using something like letsencrypt | ||
# apiVersion: cert-manager.io/v1 | ||
# kind: ClusterIssuer | ||
# metadata: | ||
# name: letsencrypt-staging | ||
# spec: | ||
# acme: | ||
# server: https://acme-staging-v02.api.letsencrypt.org/directory | ||
# email: "bryan.fauble@sagebase.org" | ||
# privateKeySecretRef: | ||
# name: letsencrypt-staging-account-key | ||
# solvers: | ||
# - http01: | ||
# gatewayHTTPRoute: | ||
# parentRefs: | ||
# - kind: Gateway | ||
# name: eg | ||
# namespace: envoy-gateway | ||
--- | ||
apiVersion: cert-manager.io/v1 | ||
kind: ClusterIssuer | ||
metadata: | ||
name: selfsigned | ||
name: lets-encrypt-prod | ||
spec: | ||
selfSigned: {} | ||
acme: | ||
server: https://acme-v02.api.letsencrypt.org/directory | ||
email: "dpe@sagebase.org" | ||
privateKeySecretRef: | ||
name: letsencrypt-prod-account-key | ||
solvers: | ||
- http01: | ||
gatewayHTTPRoute: | ||
parentRefs: | ||
- kind: Gateway | ||
name: eg | ||
namespace: envoy-gateway |
16 changes: 16 additions & 0 deletions
16
modules/envoy-gateway/resources/http-to-https-redirect.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# Upgrades HTTP requests to HTTPS | ||
apiVersion: gateway.networking.k8s.io/v1 | ||
kind: HTTPRoute | ||
metadata: | ||
name: tls-redirect | ||
spec: | ||
parentRefs: | ||
- name: eg | ||
sectionName: http | ||
hostnames: | ||
- "*.sagedpe.org" | ||
rules: | ||
- filters: | ||
- type: RequestRedirect | ||
requestRedirect: | ||
scheme: https |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was causing us issues to apply a blanket SecurityPolicy at the gateway to require JWT be provided due to the nature of how the ACME challenge needs to be solved:
https://letsencrypt.org/docs/challenge-types/#http-01-challenge
Because JWT was required the traffic to solve the challenge was being rejected due to HTTP 401.
Instead, we will expect that security policies will be individually applied to all HTTP Routes that are created for the cluster - Like what is already in place for the telemetry endpoints: Like what is shown in this file