Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public and Hardcoded Author Information & Other Bugs #84

Open
Anikketsingh opened this issue May 15, 2024 · 2 comments
Open

Public and Hardcoded Author Information & Other Bugs #84

Anikketsingh opened this issue May 15, 2024 · 2 comments
Assignees
Labels
good first issue Good for newcomers gssoc GSSOC'2024 GirlScript Summer of Code | Contributor

Comments

@Anikketsingh
Copy link

Description:
There are several issues in the provided code that need to be addressed:

Hardcoded Author Information:

Sensitive information about the admin user, including email, password, full name, and mobile number, is hardcoded in the code. This poses a significant security risk and violates best practices for handling sensitive data.
Inconsistent Error Handling:

Some routes do not handle errors consistently, leading to potential internal server errors without proper feedback to the client.
Code Structure and Redundancy:

The code for rendering the admin dashboard is repeated multiple times across different routes, making it harder to maintain and increasing the chance of bugs.
Screenshot 2024-05-15 at 12 56 55 PM

Miscellaneous Errors:

Minor typos and mistakes, such as res.status(500).jso({ error: "Internal server error" }); which should be res.status(500).json({ error: "Internal server error" });.

Copy link

Congratulations, @Anikketsingh! 🎉 Thank you for creating your issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work!

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@Sahil1786 Sahil1786 added good first issue Good for newcomers GSSOC'2024 GirlScript Summer of Code | Contributor level1 gssoc and removed level1 labels May 15, 2024
@Saloni1707
Copy link

@Sahil1786 I would like to work on this issue !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers gssoc GSSOC'2024 GirlScript Summer of Code | Contributor
Projects
None yet
Development

No branches or pull requests

3 participants