Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Cocoapods integration #42

Open
yllfejziu opened this issue Dec 19, 2023 · 4 comments
Open

Support Cocoapods integration #42

yllfejziu opened this issue Dec 19, 2023 · 4 comments

Comments

@yllfejziu
Copy link

Current Situation:

  • The K1 library currently supports only Swift Package Manager.
  • CocoaPods is a widely used dependency manager in the iOS community.

Suggested Enhancement:

  • Add support for CocoaPods in the K1 library.

Benefits:

  • This would make K1 more accessible to a broader range of developers.
  • It provides an alternative for those who prefer CocoaPods over SPM.
  • Cocoapods is more friendly for react-native community
@Sajjon
Copy link
Owner

Sajjon commented Dec 25, 2023

@yllfejziu Merry Christmas! thanks for opening the issue, sure I can add Cocoapods support, will do it a bit later when Christmas Holidays are over.

Feel free to nudge me in a week or so if I forgot about it! 😅

PRs are always welcome ofc!

@yllfejziu
Copy link
Author

@Sajjon

Thanks for the reply! Hope you are enjoying your holidays... 😄

I'm gonna need the SPM support later on when I'll use K1 package in a react-native library, so just wanted to check on the progress of this issue.

Hoping this gets resolved by then (1-2 weeks), if not, I'll definitely open a PR myself.

Thank you 🙌

@yllfejziu
Copy link
Author

Hey @Sajjon,

I'm trying to support Cocoapods on K1 but I'm stumbling on some issues when referencing source files (headers etc).
These issues arise due to the git submodule included which has a lot of exact filenames under different directories.
(Check this cocoapods issue: CocoaPods/CocoaPods#8289)

I made some progress on the .podspec file definition, and you can watch it here:
https://github.com/yllfejziu/K1/blob/main/K1.podspec

Since you have a deeper understanding of the corresponding files for each module, can you help me out finish this?

Thanks in advance.

@Sajjon
Copy link
Owner

Sajjon commented Jan 15, 2024

@yllfejziu thank you for taking trying, did you see this: https://github.com/Boilertalk/secp256k1.swift/blob/master/secp256k1.swift.podspec

perhaps that might help, might worth another try? Otherwise we will have to wait until have find some extra time over....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants