-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test coverage for slas commands #288
Labels
Comments
@hnestmann @johnboxall @jbachelet Any thoughts from your side? |
Yes I am fully on board to increase test coverage. Howeber - would unit tests help if dependencies change? Maybe we should think about integration tests with github actions or the like |
True for this particular issue. Having a CLI based test would have caught
it however.
|
I will add unit tests for sure though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#270 has introduced as breaking change as we've upgraded to a new major version of node-fetch. This caused slas commands to fail, reported in #280. A fix has been provided as part of #285. However, we should add unit tests and CLI functional tests to have some safeguards in place to prevent this from happening again.
The text was updated successfully, but these errors were encountered: