Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stencil] Update ResponseTimeInterceptor #76

Open
techsavvyash opened this issue Feb 5, 2024 · 4 comments · May be fixed by #150
Open

[stencil] Update ResponseTimeInterceptor #76

techsavvyash opened this issue Feb 5, 2024 · 4 comments · May be fixed by #150
Assignees
@Savio629 @DarrenDsouza7273

Comments

@techsavvyash
Copy link
Member

techsavvyash commented Feb 5, 2024 •
edited
Loading

Description

The ResponseTimeInterceptor in stencil currently depends on creating the response-times.json dashboard JSON file locally on disk, this is a seriously flawed way to do things and this implementation should be moved to using the Official Grafana Dashboard's API

Complexity : Medium

Product Name

Stencil

Organisation Name

SamagraX

Domain

Monitoring

Tech Skills Needed

TypeScript, Grafana

Ref: https://github.com/SamagraX-Stencil/stencil/tree/fix/response-time-interceptor
@techsavvyash techsavvyash self-assigned this Feb 5, 2024
@techsavvyash techsavvyash removed their assignment May 21, 2024
@techsavvyash techsavvyash mentioned this issue Jul 2, 2024
Closed
@techsavvyash
Copy link
Member Author

  • changes are required to be made in the JSON generator for API migration. Requires a day or two to be done.

@techsavvyash
Copy link
Member Author

  • The Grafana APIs are erroring out with the current JSON.
  • Panels are not getting created
  • JSONs are different

@Savio629
Copy link
Collaborator

Savio629 commented Jul 3, 2024

Ref:

@DarrenDsouza7273 DarrenDsouza7273 linked a pull request Jul 4, 2024 that will close this issue
Open
@techsavvyash
Copy link
Member Author

techsavvyash commented Jul 4, 2024 •
edited by Savio629
Loading

@Savio629 @DarrenDsouza7273 to do this

  • Test for multiple instances of the interceptor
  • Addition of test cases

@techsavvyash techsavvyash linked a pull request Jul 6, 2024 that will close this issue
[93] fix: Connected Grafana Api to the response-time-interceptor #150
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Savio629 Savio629

@DarrenDsouza7273 DarrenDsouza7273

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[93] fix: Connected Grafana Api to the response-time-interceptor DarrenDsouza7273/stencil
3 participants
@techsavvyash @Savio629 @DarrenDsouza7273