-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a compact mode to the OSC #208
Comments
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
What do you guys think about this layout? Also solves #264 Changes:
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Test script: compact_osc/modernz.lua Please test and let me know if there are any issues or changes that need to be made. Changes:
Pinging @Keith94 and @Xurdejl as they have shown interest in compact mode. |
Wow, compact mode is so cool! Thanks! |
This comment was marked as resolved.
This comment was marked as resolved.
Updated: compact_osc/modernz.lua Changes:
Wouldn't this break "standard"? Most OSCs (local and online players) have I'm not rejecting this specific suggestion, I'm just concerned on user experience. Do you think we should instead make the volume bar a user option? ie: show volume icon only if need be. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Updated script. (Same link) Changes:
I tested them, that prefix is the only one that is kind of visible lol. Not sure if I should keep it or not, to be honest. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Updated: compact_osc/modernz.lua Changes:
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Updated: compact_osc/modernz.lua Changes:
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I asked the same question on the feature request for cache, and they said to enable for all types. I also only use cache speed for online videos only, so I enable it with my Stream auto profile
Will try to fix as best as I can.
Great idea. I'll use
The mpv users would crucify me if I did that lol. We can maybe introduce a feature in the future to customize time display behavior |
Updated: compact_osc/modernz.lua Changes:
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Yeah, not at all.. It used to show just the speed properly and cache time was invisible. Commit 87478e5 made it so speed doesn't show up now. Feels like I made a simple mistake somewhere lol. |
Hmmm. Could it be related to your cache options in ### Cache
cache=yes
demuxer-max-bytes=400MiB
demuxer-max-back-bytes=200MiB Also, in my media auto profile it changes to: [Media]
profile-desc=Apply options for Movies and TV Shows directories
profile-cond=get('path', ''):match('\\Movies\\') or get('path', ''):match('\\TV Shows\\') or get('path', ''):match('^X:\\')
profile-restore=copy-equal
demuxer-max-bytes=1500MiB
demuxer-max-back-bytes=500MiB |
Ahh, thank you. You found my simple mistake. I left mpv's cache option alone which defaults to auto. When I set it to yes I can see the cache finally. I guess if you set yours to "auto" or "no" then you should be able to reproduce that tooltip over invisible cache thingy. Hopefully. |
Good point. Tooltip should only show if cache is shown. |
Updated: compact_osc/modernz.lua Changes:
@Keith94 I learned something new because of this bug. If you want to display |
Edit; nvm, I think it may already be doing that. It's late. |
Expected behavior of the wanted feature
By moving the remaining time and total time in front and in the end of the progress bar , the OSC can be more compact
The text was updated successfully, but these errors were encountered: