Skip to content

Commit

Permalink
ci: Update Linter & add Linter badge
Browse files Browse the repository at this point in the history
Signed-off-by: Taras Drozdovskyi <t.drozdovsky@samsung.com>
  • Loading branch information
tdrozdovsky committed Feb 20, 2024
1 parent d48a3eb commit 4773a59
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 14 deletions.
19 changes: 9 additions & 10 deletions .github/workflows/linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,20 @@ jobs:
cpp-linter:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: cpp-linter/cpp-linter-action@v2
- uses: actions/checkout@v4
- uses: cpp-linter/cpp-linter-action@main
id: linter
continue-on-error: true
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
style: file
# The following value will only update a single comment
# in a pull request's thread. Set it to false to disable the comment.
# Set it to true to post a new comment (and delete the old comment).
# thread-comments: ${{ github.event_name == 'pull_request' && 'update' }}
thread-comments: ${{ github.event_name == 'push' && 'update' }}
style: ''
files-changed-only: false
ignore: crypto

- name: Fail fast?!
if: steps.linter.outputs.checks-failed > 0
run: echo "Some files failed the linting checks!"
if: steps.linter.outputs.checks-failed != 0
run: |
echo "some linter checks failed. ${{ steps.linter.outputs.checks-failed }}"
# for actual deployment
# run: exit 1
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
[![Build](https://github.com/samsung/mtower/workflows/Build/badge.svg)](https://github.com/samsung/mtower/actions?query=workflow%3ABuild)
[![CII Best Practices](https://bestpractices.coreinfrastructure.org/projects/6108/badge)](https://bestpractices.coreinfrastructure.org/projects/6108)
[![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/Samsung/mTower/badge)](https://api.securityscorecards.dev/projects/github.com/Samsung/mTower)
[![cpp-linter](https://github.com/cpp-linter/cpp-linter-action/actions/workflows/cpp-linter.yml/badge.svg)](https://github.com/cpp-linter/cpp-linter-action/actions/workflows/cpp-linter.yml)
[![RepoSize](https://img.shields.io/github/repo-size/samsung/mtower.svg)](https://github.com/samsung/mtower)
[![Release](https://img.shields.io/github/v/release/samsung/mtower.svg)](https://github.com/samsung/mtower/releases)
[![LICENSE](https://img.shields.io/github/license/samsung/mtower.svg)](https://github.com/samsung/mtower/blob/master/LICENSE)
Expand Down
2 changes: 1 addition & 1 deletion apps/hello_world/ca/hello_world_ns.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
#include <stdio.h>
#include <string.h>

#include <tee_client_api.h>
#include "tee_client_api.h"

Check failure on line 32 in apps/hello_world/ca/hello_world_ns.c

View workflow job for this annotation

GitHub Actions / cpp-linter

apps/hello_world/ca/hello_world_ns.c:32:10 [clang-diagnostic-error]

'tee_client_api.h' file not found

/* To the the UUID (found the the TA's h-file(s)) */
#include <hello_world_ta.h>
Expand Down
6 changes: 3 additions & 3 deletions tools/ecdsa_keygen.c
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,11 @@ typedef struct Message_Struct {

/* Private Data. */
/* All static data definitions appear here. */
uint32_t key[] =
const uint32_t key[] =
{ 0x78563412, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0xefcdac00 };

uint32_t iv[] =
const uint32_t iv[] =
{ 0x78563412, 0x00000000, 0x00000000, 0xefcdac00 };

/* Public Data. */
Expand Down Expand Up @@ -374,7 +374,7 @@ int main(int argc, char * argv[])
}
fclose(fd);

exit:
// exit:
BN_free(x);
BN_free(y);
EC_GROUP_free(ecgroup);
Expand Down

0 comments on commit 4773a59

Please sign in to comment.