fixed AutoOnLux

Schmakus · Sep 22, 2023 · 139d40b · 139d40b
1 parent dda5a86
commit 139d40b
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 12 deletions.
diff --git a/README.md b/README.md
@@ -56,6 +56,12 @@ iobroker add lightcontrol
 	Placeholder for the next version (at the beginning of the line):
 	### **WORK IN PROGRESS**
 -->
+
+### **WORK IN PROGRESS**
+
+-   (Schmakus) update dependencies
+-       (Schmakus) fixed AutoOnLux (Cannot read properties of undefined (reading 'minLux'))
+
 ### 0.4.0 (2023-08-16)
 
 -   (Schmakus) Node >=16 and NPM >=7 necessary!

diff --git a/lib/switchingOnOff.js b/lib/switchingOnOff.js
@@ -498,18 +498,25 @@ async function AutoOnLux(adapter, Group) {
 	const LightGroups = adapter.LightGroups;
 	try {
 		adapter.log.debug(
-			`Reaching AutoOnLux for Group="${Group} enabled="${LightGroups[Group].autoOnLux?.enabled}", actuallux="${LightGroups[Group].actualLux}", minLux="${LightGroups[Group].autoOnLux.minLux}" LightGroups[Group].autoOnLux.dailyLock="${LightGroups[Group].autoOnLux.dailyLock}"`,
+			`Reaching AutoOnLux for Group="${Group} enabled="${LightGroups[Group].autoOnLux?.enabled}", actuallux="${LightGroups[Group].actualLux}", minLux="${LightGroups[Group].autoOnLux?.minLux}" LightGroups[Group].autoOnLux.dailyLock="${LightGroups[Group].autoOnLux?.dailyLock}"`,
 		);
 
 		let tempBri = 0;
 		let tempColor = "";
 
-		if (LightGroups[Group].autoOnLux.operator == "<") {
+		let minLux = 500;
+
+		if (LightGroups[Group].autoOnLux?.minLux === undefined) {
+			minLux = 500;
+			adapter.writeLog(`[ AutoOnLux ] No minLux defined for Group="${Group}". Use default minLux of 500lux`);
+		}
+
+		if (LightGroups[Group].autoOnLux?.operator == "<") {
 			if (
 				LightGroups[Group].autoOnLux?.enabled &&
 				!LightGroups[Group].power &&
 				!LightGroups[Group].autoOnLux?.dailyLock &&
-				LightGroups[Group].actualLux <= LightGroups[Group].autoOnLux?.minLux
+				LightGroups[Group].actualLux <= minLux
 			) {
 				adapter.log.info(`AutoOn_Lux() activated Group="${Group}"`);
 
@@ -533,10 +540,7 @@ async function AutoOnLux(adapter, Group) {
 				LightGroups[Group].autoOnLux.dailyLock = true;
 
 				await adapter.setStateAsync(Group + ".autoOnLux.dailyLock", true, true);
-			} else if (
-				LightGroups[Group].autoOnLux.dailyLock &&
-				LightGroups[Group].actualLux > LightGroups[Group].autoOnLux.minLux
-			) {
+			} else if (LightGroups[Group].autoOnLux.dailyLock && LightGroups[Group].actualLux > minLux) {
 				//DailyLock zurücksetzen
 
 				LightGroups[Group].autoOnLux.dailyLockCounter++;
@@ -555,7 +559,7 @@ async function AutoOnLux(adapter, Group) {
 				LightGroups[Group].autoOnLux.enabled &&
 				!LightGroups[Group].power &&
 				!LightGroups[Group].autoOnLux.dailyLock &&
-				LightGroups[Group].actualLux >= LightGroups[Group].autoOnLux.minLux
+				LightGroups[Group].actualLux >= minLux
 			) {
 				adapter.log.info(`AutoOn_Lux() activated Group="${Group}"`);
 
@@ -578,10 +582,7 @@ async function AutoOnLux(adapter, Group) {
 
 				LightGroups[Group].autoOnLux.dailyLock = true;
 				await adapter.setStateAsync(Group + ".autoOnLux.dailyLock", true, true);
-			} else if (
-				LightGroups[Group].autoOnLux.dailyLock &&
-				LightGroups[Group].actualLux < LightGroups[Group].autoOnLux.minLux
-			) {
+			} else if (LightGroups[Group].autoOnLux.dailyLock && LightGroups[Group].actualLux < minLux) {
 				//DailyLock zurücksetzen
 
 				LightGroups[Group].autoOnLux.dailyLockCounter++;