-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we use opencv-headless? #104
Comments
Not using headless leads to some Qt binaries being included in the build, which can mess things up when we include in something using PySide etc. Like this, opencv/opencv-python#46 |
@tdowrick @MattClarkson I'm looking at using opencv-contrib-python-headless here to try and avoid downstream library conflicts with PySide2 (and just to simplify dependencies in general). This would break anything here with a GUI, namely sksurgeryimage/display/identify_cameras.py and sksurgeryimage/ui/ImageCropper.py. However neither of them appear to be integral to sksurgeryimage, they just seem to be useful utilities. If we want to keep them we could just move them to a separate library that has a GUI. Do either of you have an opinion on this? |
I don't think either of those two are used anymore, or can be moved if needed, so I think you can go ahead and make the change. |
@thompson318 - turns out these things are referenced in BARD. Can we re-open? The question is also which packaged need updating, as some have a requirements.txt that explicitly names opencv-python-contrib as well, so you'd get both. |
Where in bard is this used? I tried to find it but couldn't see the import statement. |
I've repopened it for now. I don't think it's used directly by BARD, but maybe in the tutorial instructions. My preference would be to update the tutorial instructions and try and use opencv-headless wherever possible. |
I can't find any reference to ImageCropper in BARD or MPHY0026 |
I am having a conflict using
@thompson318, can we go for a scikit-surgeryimage new release v0.11.0, fixing |
I don't understand why pip is choosing arucotracker 0.2.8. I can see it doing it here: |
No description provided.
The text was updated successfully, but these errors were encountered: