Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tapir => Mooncake renaming #88

Closed
gdalle opened this issue Sep 23, 2024 · 4 comments
Closed

Tapir => Mooncake renaming #88

gdalle opened this issue Sep 23, 2024 · 4 comments

Comments

@gdalle
Copy link
Collaborator

gdalle commented Sep 23, 2024

@willtebbutt @yebai I think we can close #76 and open a new PR that

  • adds AutoMooncake with the right type parameters and fields (don't get it wrong, as you saw we're not keen on breaking changes around here ^^)
  • puts a deprecation warning on AutoTapir

What do you say?

@gdalle gdalle changed the title Tapir -> Mooncake renaming Tapir => Mooncake renaming Sep 23, 2024
@willtebbutt
Copy link
Contributor

Yup, will do.

Re correct type parameters and parameter names: would you object to us parametrising them flexibly? i.e. doing something like

struct AutoMooncake{Tconfig<:Mooncake.Config}
    config::Tconfig
end

config = Mooncake.Config(...)
ADTypes.AutoMooncake(; config)

where Mooncake.Config is a general configuration handling thing that we may change when we release breaking versions of Mooncake. This way we have some flexibility, while not risking requiring breaking changes to the ADTypes interface.

@gdalle
Copy link
Collaborator Author

gdalle commented Sep 24, 2024

Sounds good to me

@gdalle
Copy link
Collaborator Author

gdalle commented Sep 24, 2024

The way things look, the Mooncake renaming in ADTypes and DI will be the last item on the to-do list before the breaking release of DI. Do ping me if I can help in any way!
Btw, the new docs of Mooncake are really cool

@gdalle
Copy link
Collaborator Author

gdalle commented Sep 25, 2024

Done in #89

@gdalle gdalle closed this as completed Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants