-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The FFJORD copy-pasteable code doesn't work #931
Labels
bug
Something isn't working
Comments
Yes, thanks for the report. The change to state makes it so the direct translation is: function cb(state, l)
@info "FFJORD Training" loss=loss(state.u)
return false
end But of course as you found, the better thing is just to use the pre-computed function cb(state, l)
@info "FFJORD Training" loss=l
return false
end This is fixed in 2691d59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The copy-pasteable FFJORD example here doesn't quite work as is.
I copy-pasted the code in a brand new
--temp
environment (only change ismaxiter=1
) and get an errorThe problem appears to be in the callback function. I don't quite understand why it doesn't work as-is, but simply replacing
loss=loss(p)
byloss=l
does the trick.The text was updated successfully, but these errors were encountered: