-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test suite not passing following recent changes #287
Comments
Thanks for bringing this up; and sorry for the very late response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi!
Thanks a lot for this great library :). I was using the latest github version but noticed that the test suite is broken. Maybe it could be good to add a github workflow running the test suite? Or at least to fix the test/code to show the correct intent :).
One of the cases I have in mind is (It's not the only one that needs fixing if I am not mistaken)
One line of the
data_test_temperature_score.csv
fileHere the
end_year
is 2020. If we go intoWe see that the last check puts
NaN
intoself.c.COLS.ANNUAL_REDUCTION_RATE
, thus giving a final temperature of 3.2, whereas in the test we find:1.77 :)
The text was updated successfully, but these errors were encountered: