Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve code from sdk examples -- document / validate hex values, explore sdk for other alt interface #56

Open
wildmolasses opened this issue Jan 20, 2023 · 0 comments
Open

improve code from sdk examples -- document / validate hex values, explore sdk for other alt interface #56

wildmolasses opened this issue Jan 20, 2023 · 0 comments

Comments

@wildmolasses
Copy link
Contributor

For all these input args where the estimate is supposed to be a hex string specifically, we should either validate that (or does railgun do that?) and/or add comments and/or a more clear variable name. This feels like something that will be confusing to people new to the codebase.

Originally posted by @mds1 in #51 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wildmolasses