Query StealthKeyChanged events from subgraph #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jolly-shaw-20fe62 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jferas
force-pushed
the
stealthkey-events-from-subgraph
branch
from
a3f01f4 to
6d831ac
Compare
alexkeating
reviewed
May 8, 2024
alexkeating
approved these changes
May 16, 2024
garyghayrat
force-pushed
the
stealthkey-events-from-subgraph
branch
from
e93a43c to
9caa3d6
Compare
garyghayrat
force-pushed
the
stealthkey-events-from-subgraph
branch
from
b0b693e to
872d22d
Compare
Co-authored-by: Gary Ghayrat <61768337+garyghayrat@users.noreply.github.com>
Co-authored-by: Gary Ghayrat <61768337+garyghayrat@users.noreply.github.com>
* fix: explicitly sort the tokens by addr * fix: use vm.computeCreateAddress * fix: mirror test sender params * fix: use actual owner * fix: add back gnosis * Remove all reference to INFURA_ID (#687) --------- Co-authored-by: John Feras <jferas@ferasinfotech.com>
jferas
force-pushed
the
stealthkey-events-from-subgraph
branch
from
5dd9ccc to
8708597
Compare
…rom the stealthBalances array
…ock number and stealthkeys
… wasteful retries from wallet function getRegisteredStealthKeys
…lock number of event in storage as starting point of announcements scan
…raph.. umbra-js change
jferas
force-pushed
the
stealthkey-events-from-subgraph
branch
from
8708597 to
798d512
Compare
|
Coverage after merging stealthkey-events-from-subgraph into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will query the Umbra subgraph for StealthKeyChanged events, in the act of acquiring the block number in which the user first registered, and for getting the user's registered StealthKeys associated with their registration address.
Should the subgraph query fail .. for whatever reason.. including the subgraph URL environment variable referencing an old-style subgraph that doesn't contain StealthKeyChanged events.. the app will "fall back" to the original approach of asking the StealthKeyRegistry contract for the information.
The new-style subgraph that contains the StealthKeyChanged events is contained in this PR on the Umbra subgraph repo.
This PR is in draft, and can be tested locally by setting the subgraph URL env vars for MAINNET or SEPOLIA to reference new (temporary) subgraph deployments on Alchemy, using the following definitions:
The javascript console logs will indicate if matching StealthKeyChanged events were found for the registration address, and additionally indicate if older StealthKeyChanged events were found for that address, as a diagnostic.
Note: This PR makes modification to UmbraJs files, and modifies the
package.jsonfile of the front-end to make use of those files. For production, a new version of UmbraJs would need to be released.