Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty JSON being saved to local storage #117

Open
cfisher-scottlogic opened this issue Nov 21, 2023 · 0 comments
Open

Empty JSON being saved to local storage #117

cfisher-scottlogic opened this issue Nov 21, 2023 · 0 comments
Assignees

Comments

@cfisher-scottlogic
Copy link

cfisher-scottlogic commented Nov 21, 2023

Background

Developers at UBS are sometimes experiencing empty JSON is being saved to local storage. It's not actively causing problems, but it could be indicative of problems earlier in the chain (e.g. React -> JSON serialization). We should ensure an empty layout definition does not get saved.

Work Required

  • Put (a) guard clause(s) in place to stop saving empty or undefined layouts for both applicationLayout and layout
  • Trigger error notificationb when save layout action is executed with empty layout {}

Notes

Related: #115 (comment)

@cfisher-scottlogic cfisher-scottlogic added this to the Layout Management milestone Nov 21, 2023
@cfisher-scottlogic cfisher-scottlogic added bug Something isn't working and removed bug Something isn't working labels Nov 21, 2023
@vferraro-scottlogic vferraro-scottlogic self-assigned this Dec 5, 2023
@vferraro-scottlogic vferraro-scottlogic linked a pull request Dec 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants