Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with saving Definition #15

Open
Alexanderererr opened this issue Aug 10, 2024 · 2 comments
Open

Problems with saving Definition #15

Alexanderererr opened this issue Aug 10, 2024 · 2 comments

Comments

@Alexanderererr
Copy link

So I edited Provinces and that editing deleted some provinces, I saved it and in Definition. The provinces I deleted get swapped with provinces all the way to the bottom, I know it's preserve-ids but if I don't enable it IDs won't show, if disabled there are only X's. Pls fix maybe THX.
Bild_2024-08-10_130632980
Bild_2024-08-10_130815625

@Alexanderererr
Copy link
Author

Got cancer reading it myself, sorry. So I meant
So I edited Provinces and that editing deleted some provinces. I saved it in Definition, The provinces I deleted get swapped with provinces all the way to the bottom, I know it's preserve-ids but if I don't enable it IDs won't show, if disabled there are only X's. Pls fix maybe THX.

@ScottyThePilot
Copy link
Owner

I believe the reason I implemented preserve-ids this way is to prevent gaps in the list of province IDs because the game might not like it. So if you delete a province in the middle of the list, it swaps one in from the bottom, changing just the ID. It's been a few years since I first implemented this so I don't remember if I've actually tested this on the game and verified whether gaps cause the game to break, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants