From f6be4f2120a708f34d58e43153fa2deaa7c195d3 Mon Sep 17 00:00:00 2001 From: Philippe Marschall Date: Sun, 20 Oct 2024 16:36:19 +0200 Subject: [PATCH] Review comments --- .../WASessionContinuation.class/instance/handle..st | 2 +- .../WASessionContinuation.class/instance/restoreState.st | 4 ++++ .../WASingleElementCacheTest.class/instance/testClear.st | 2 +- .../instance/testKeyAtValue.st | 4 ++-- .../instance/testKeysAndValuesDo.st | 2 +- .../WASingleElementCacheTest.class/instance/testSize.st | 6 +++--- .../WASingleElementCacheTest.class/instance/testStore.st | 6 +++--- .../instance/handle..st | 4 ---- .../instance/restoreState.st | 3 +++ .../class/initialize.st | 7 ++++++- 10 files changed, 24 insertions(+), 16 deletions(-) create mode 100644 repository/Seaside-Session.package/WASessionContinuation.class/instance/restoreState.st delete mode 100644 repository/Seaside-WebComponents-Core.package/WAWebComponentActionContinuation.class/instance/handle..st create mode 100644 repository/Seaside-WebComponents-Core.package/WAWebComponentActionContinuation.class/instance/restoreState.st diff --git a/repository/Seaside-Session.package/WASessionContinuation.class/instance/handle..st b/repository/Seaside-Session.package/WASessionContinuation.class/instance/handle..st index 99744e2f2..c3e2a2647 100644 --- a/repository/Seaside-Session.package/WASessionContinuation.class/instance/handle..st +++ b/repository/Seaside-Session.package/WASessionContinuation.class/instance/handle..st @@ -2,5 +2,5 @@ handling handle: aRequestContext "Resume processing of a request. To ensure valid application state restore all registered states." - self states restore. + self restoreState. self withUnregisteredHandlerDo: [ super handle: aRequestContext ] \ No newline at end of file diff --git a/repository/Seaside-Session.package/WASessionContinuation.class/instance/restoreState.st b/repository/Seaside-Session.package/WASessionContinuation.class/instance/restoreState.st new file mode 100644 index 000000000..cc792ac5b --- /dev/null +++ b/repository/Seaside-Session.package/WASessionContinuation.class/instance/restoreState.st @@ -0,0 +1,4 @@ +processing +restoreState + + self states restore \ No newline at end of file diff --git a/repository/Seaside-Tests-WebComponents.package/WASingleElementCacheTest.class/instance/testClear.st b/repository/Seaside-Tests-WebComponents.package/WASingleElementCacheTest.class/instance/testClear.st index 15d54689a..cfa06970f 100644 --- a/repository/Seaside-Tests-WebComponents.package/WASingleElementCacheTest.class/instance/testClear.st +++ b/repository/Seaside-Tests-WebComponents.package/WASingleElementCacheTest.class/instance/testClear.st @@ -2,4 +2,4 @@ testing testClear cache at: 1 put: 'one'. cache clear. - self assert: (cache at: 1 ifAbsent: [ 'two' ]) = 'two'. \ No newline at end of file + self assert: (cache at: 1 ifAbsent: [ 'two' ]) equals: 'two'. \ No newline at end of file diff --git a/repository/Seaside-Tests-WebComponents.package/WASingleElementCacheTest.class/instance/testKeyAtValue.st b/repository/Seaside-Tests-WebComponents.package/WASingleElementCacheTest.class/instance/testKeyAtValue.st index b45feec56..b214dd2eb 100644 --- a/repository/Seaside-Tests-WebComponents.package/WASingleElementCacheTest.class/instance/testKeyAtValue.st +++ b/repository/Seaside-Tests-WebComponents.package/WASingleElementCacheTest.class/instance/testKeyAtValue.st @@ -1,5 +1,5 @@ testing testKeyAtValue cache at: 1 put: 'one'. - self assert: (cache keyAtValue: 'one' ifAbsent: [ 2 ]) = 1. - self assert: (cache keyAtValue: 'two' ifAbsent: [ 2 ]) = 2. \ No newline at end of file + self assert: (cache keyAtValue: 'one' ifAbsent: [ 2 ]) equals: 1. + self assert: (cache keyAtValue: 'two' ifAbsent: [ 2 ]) equals: 2. \ No newline at end of file diff --git a/repository/Seaside-Tests-WebComponents.package/WASingleElementCacheTest.class/instance/testKeysAndValuesDo.st b/repository/Seaside-Tests-WebComponents.package/WASingleElementCacheTest.class/instance/testKeysAndValuesDo.st index 314f908aa..020fd452e 100644 --- a/repository/Seaside-Tests-WebComponents.package/WASingleElementCacheTest.class/instance/testKeysAndValuesDo.st +++ b/repository/Seaside-Tests-WebComponents.package/WASingleElementCacheTest.class/instance/testKeysAndValuesDo.st @@ -10,4 +10,4 @@ testKeysAndValuesDo cache keysAndValuesDo: [ :key :value | readBack at: key put: value ]. - self assert: readBack = reference \ No newline at end of file + self assert: readBack equals: reference \ No newline at end of file diff --git a/repository/Seaside-Tests-WebComponents.package/WASingleElementCacheTest.class/instance/testSize.st b/repository/Seaside-Tests-WebComponents.package/WASingleElementCacheTest.class/instance/testSize.st index ec347265f..336f14a99 100644 --- a/repository/Seaside-Tests-WebComponents.package/WASingleElementCacheTest.class/instance/testSize.st +++ b/repository/Seaside-Tests-WebComponents.package/WASingleElementCacheTest.class/instance/testSize.st @@ -1,7 +1,7 @@ testing testSize - self assert: cache size = 0. + self assert: cache size equals: 0. cache at: 1 put: 'one'. - self assert: cache size = 1. + self assert: cache size equals: 1. cache at: 2 put: 'two'. - self assert: cache size = 1. \ No newline at end of file + self assert: cache size equals: 1. \ No newline at end of file diff --git a/repository/Seaside-Tests-WebComponents.package/WASingleElementCacheTest.class/instance/testStore.st b/repository/Seaside-Tests-WebComponents.package/WASingleElementCacheTest.class/instance/testStore.st index a4db49ee5..64de69d88 100644 --- a/repository/Seaside-Tests-WebComponents.package/WASingleElementCacheTest.class/instance/testStore.st +++ b/repository/Seaside-Tests-WebComponents.package/WASingleElementCacheTest.class/instance/testStore.st @@ -5,6 +5,6 @@ testStore WAKeyGenerator use: generator during: [ - self assert: (cache store: 'key1') = 1. - self assert: (cache store: 'key2') = 2. - self assert: (cache store: 'key3') = 3 ] \ No newline at end of file + self assert: (cache store: 'key1') equals: 1. + self assert: (cache store: 'key2') equals: 2. + self assert: (cache store: 'key3') equals: 3 ] \ No newline at end of file diff --git a/repository/Seaside-WebComponents-Core.package/WAWebComponentActionContinuation.class/instance/handle..st b/repository/Seaside-WebComponents-Core.package/WAWebComponentActionContinuation.class/instance/handle..st deleted file mode 100644 index cb192651d..000000000 --- a/repository/Seaside-WebComponents-Core.package/WAWebComponentActionContinuation.class/instance/handle..st +++ /dev/null @@ -1,4 +0,0 @@ -handling -handle: aRequestContext - "don't restore states" - self withUnregisteredHandlerDo: [ super handle: aRequestContext ] \ No newline at end of file diff --git a/repository/Seaside-WebComponents-Core.package/WAWebComponentActionContinuation.class/instance/restoreState.st b/repository/Seaside-WebComponents-Core.package/WAWebComponentActionContinuation.class/instance/restoreState.st new file mode 100644 index 000000000..faf0810b4 --- /dev/null +++ b/repository/Seaside-WebComponents-Core.package/WAWebComponentActionContinuation.class/instance/restoreState.st @@ -0,0 +1,3 @@ +processing +restoreState + "don't restore states" \ No newline at end of file diff --git a/repository/Seaside-WebComponents-Examples.package/WAWebComponentsDemoApplication.class/class/initialize.st b/repository/Seaside-WebComponents-Examples.package/WAWebComponentsDemoApplication.class/class/initialize.st index 2c3ed2e96..ce78a79b1 100644 --- a/repository/Seaside-WebComponents-Examples.package/WAWebComponentsDemoApplication.class/class/initialize.st +++ b/repository/Seaside-WebComponents-Examples.package/WAWebComponentsDemoApplication.class/class/initialize.st @@ -1,4 +1,9 @@ initialization initialize - (WAAdmin register: self asApplicationAt: 'examples/web-components') + | application | + "register such that we do not have the developer tools" + application := WAAdmin register: WAApplication at: 'examples/web-components' in: WAAdmin defaultDispatcher. + application configuration addParent: WARenderLoopConfiguration instance. + application + rootClass: self; scriptGeneratorClass: WANullScriptGenerator \ No newline at end of file