Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give a good error for duplicated fields #4

Open
Seelengrab opened this issue Jun 7, 2023 · 0 comments
Open

Give a good error for duplicated fields #4

Seelengrab opened this issue Jun 7, 2023 · 0 comments
Labels
errors Related to error messages & their UX good first issue Good for newcomers

Comments

@Seelengrab
Copy link
Owner

Seelengrab commented Jun 7, 2023 •
edited
Loading

It would be nice to be able to point at the exact fields that are duplicated, instead of just pointing out that they are.

FieldFlags.jl/src/FieldFlags.jl

Line 155 in 9d9591e

allunique(filter(!=(:_), fieldtuple)) || throw(ArgumentError("Fields need to be uniquely identifiable!"))

FieldFlags.jl/src/FieldFlags.jl

Line 514 in 9d9591e

allunique(filter(!=(:_), fields)) || throw(ArgumentError("Fields need to be uniquely identifiable!"))

@Seelengrab Seelengrab added enhancement errors Related to error messages & their UX good first issue Good for newcomers and removed enhancement labels Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
errors Related to error messages & their UX good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Seelengrab