You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not isolated to this PR, but noting that we seem to be a little inconsistent across the new and old outlier detectors wrt to when data_type is hard-coded, and when it is optionally set via a kwarg. For some, it is hardcoded to time-series (which makes sense), for some (e.g. the old Mahalanobis) it is set via kwarg, and for some it is hard coded to numeric. Maybe worth opening an issue to review this more generally?
Already mentioned in #567 (comment), but highlighting here since we are setting data_type in new detectors too...
The text was updated successfully, but these errors were encountered:
mauicv
changed the title
Not isolated to this PR, but noting that we seem to be a little inconsistent across the new and old outlier detectors wrt to when data_type is hard-coded, and when it is optionally set via a kwarg. For some, it is hardcoded to time-series (which makes sense), for some (e.g. the old Mahalanobis) it is set via kwarg, and for some it is hard coded to numeric. Maybe worth opening an issue to review this more generally?
Review data_type in meta
Jun 12, 2023
In the case of the new outlier detectors, the expectation is that they're all tabular-numeric. If the user has image or text data they need to do some preprocessing first. This assumption isn't true for detectors like the old mahalanobis outlier detector which can take categorical or numeric data for instance.
Originally posted by @ascillitoe in #746 (comment)
The text was updated successfully, but these errors were encountered: