Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs) Updated the name from v2 to OIP #6030

Merged
merged 4 commits into from
Nov 10, 2024

Conversation

Rajakavitha1
Copy link
Contributor

@Rajakavitha1 Rajakavitha1 commented Nov 6, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
I have not updated the references in https://github.com/SeldonIO/seldon-core/blob/f993cbb2c96043168ee59b1d6386ec3880f42eb3/notebooks/explainer_examples_v2.ipynb. This I hope the developer does.

@CLAassistant
Copy link

CLAassistant commented Nov 6, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Rajakavitha1
❌ Rakavitha Kodhandapani


Rakavitha Kodhandapani seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@matthewlowdon matthewlowdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, but I added one comment to consider.

Copy link
Member

@lc525 lc525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestions to remove "incubating" in a number of places. The OIP is now established and the only thing we'd like to support moving forward.

Rajakavitha1 and others added 3 commits November 10, 2024 11:59
Co-authored-by: Lucian Carata <lc525@users.noreply.github.com>
Co-authored-by: Lucian Carata <lc525@users.noreply.github.com>
Co-authored-by: Lucian Carata <lc525@users.noreply.github.com>
@Rajakavitha1 Rajakavitha1 merged commit 5509dc0 into master Nov 10, 2024
10 of 13 checks passed
@Rajakavitha1 Rajakavitha1 deleted the DR-648/v2_to_open_inference branch November 10, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants