fix(cli): Add error topic to pipeline inspect #6117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakoush
commented
Nov 27, 2024
| @@ -21,8 +21,6 @@ COPY --from=certs /etc/ssl/certs/ca-bundle.crt /etc/pki/tls/certs/ca-bundle.crt | |||
| COPY --from=certs /etc/ssl/certs/ca-bundle.crt /tmp/certs/kafka/broker/ca.crt | |||
| RUN chmod -R 777 /tmp/certs/ | |||
|
|
|||
| USER 1000 | |||
There was a problem hiding this comment.
@driev this has caused some issues. I will leave it for now. If not specifying the user is a security concern then we have to fix it for most of our images not only this one.
driev
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds kafka error topic to the cli pipeline inspect consumer, so that in the cases of errors we have return back relevant messages. cc: @paulb-seldon
This change also fixes some docs and CI.
Which issue(s) this PR fixes:
Fixes INFRA-1269 (internal)
Special notes for your reviewer: