Upgraded to bevy 0.14 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioRibera
approved these changes
Aug 11, 2024
|
Hey, thanks so much for the PR, I haven't had time to do the update, but indeed that lines up with what I was hoping it would do, I'll check out the other PR right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a pull-request to your bevy_tweening fork as well.
The behavior of the examples is a bit different now but after looking at their code, it looks like it's more correct now?
For example with the simple example both the text and brand image appear and disappear at the same time now, which seems in line with what the code tries to do, but maybe I misunderstood something.
Also text is centered now instead of slightly offset to the left.