Skip to content
This repository has been archived by the owner on Nov 8, 2023. It is now read-only.

Cleanup /dashboard.tsx code #9

Open
ShaneMaglangit opened this issue Oct 22, 2023 · 4 comments
Open

Cleanup /dashboard.tsx code #9

ShaneMaglangit opened this issue Oct 22, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest-accepted help wanted Extra attention is needed

Comments

@ShaneMaglangit
Copy link
Owner

ShaneMaglangit commented Oct 22, 2023

Description

This is a very early prototype of this project. The /dashboard was done with getting it working as soon as possible in mind, we would want to clean up this page and decouple some components/logic off the file.

Some Design Philosophies

  • Do not move components to a new file just cause.
    • If a component is strictly used within this page and we don't expect it to be used anywhere else, we would rather keep it in the same file.
      • i.e. it doesn't make sense to move it as an exported component is we're only ever going to import it once on the same file, ad infinitum.
      • this just adds unnecessary complexity and makes its more difficult to track down files/components.
      • if there's a good treason to move it into a dedicated file, please do.
  • Keep things consistent.
    • i.e. In the current implementation, we have parts where we destructure useQuery() or do something like const value = query.data ?? []. I prefer the former of destructing the query const { data, isLoading } = api...useQuery(). Ideally we do this for everything.
    • please apply this to all instances where we are doing different methods to achieve the same thing.
@ShaneMaglangit ShaneMaglangit added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest-accepted labels Oct 22, 2023
@vaibhavshah03
Copy link

Assign me this issue

@ShaneMaglangit
Copy link
Owner Author

ShaneMaglangit commented Oct 22, 2023

@vaibhavshah03 All yours 😄

Note: This issue will be open for others to grab after 7 days of inactivity.

@ShaneMaglangit
Copy link
Owner Author

Hi @vaibhavshah03 👋 Just wanted to check-in since this has been stale for a week.

How's the progress on this issue? Do you need any help to getting your code submission up?

@ShaneMaglangit
Copy link
Owner Author

Opening this up for anyone interested 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest-accepted help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants