sharinpix-move album node package #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bin/moveInterface.coffee
Outdated
| else | ||
| console.error "Error: Could not find file #{ filePath }." | ||
| else | ||
| console.error 'Error: Wrong number of arguments.' |
There was a problem hiding this comment.
donner le nombre de paramètres attendus + exemple de commande
moveAlbum.coffee
Outdated
| albums = [] | ||
|
|
||
| csv | ||
| .fromStream stream, headers: true |
kherinwork
requested review from
ombr and
kevanmoothien
and removed request for
ombr and
kevanmoothien
azharbeebeejaun
approved these changes
Jul 30, 2018
ombr
reviewed
Sep 8, 2018
moveAlbum.coffee
Outdated
| body= | ||
| 'album': | ||
| 'public_id': destination_id | ||
| superagent |
There was a problem hiding this comment.
@kherinwork plutot que d'utiliser superagent ici, tu peux simplement faire sharinpix.getInstance.post()
Si tu veux encore faire mieux tu peux faire une PR qui ajoute la fonctione renameAlbum ou moveAlbum sur le répo de SharinPix.
moveAlbum.coffee
Outdated
| albums = [] | ||
|
|
||
| csv | ||
| .fromStream stream, headers: true |
There was a problem hiding this comment.
Je pense que on ne veux pas les headers, pour faire simple et être sur de ne pas rater d'import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.