Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Improved 404 handling #1427

Closed
DonKoko opened this issue Nov 15, 2024 · 0 comments
Closed

Feat: Improved 404 handling #1427

DonKoko opened this issue Nov 15, 2024 · 0 comments
Assignees

Comments

@DonKoko
Copy link
Contributor

DonKoko commented Nov 15, 2024

Because of how our app is made, we need to do some special 404 handling.

Current situation

  1. You are added to workspace A and workspace B
  2. You are currently in workspace A
  3. You try to access an entry that is in workspace B
  4. You get a 404.

This can be very frustrating for users so we need to handle it in a more advanced/better way.
We still need to see how to do it technically, but the general concept is that if that case happens, instead of showing an error boundary we render a screen saying something like:

The ${entry.model.name} you are trying to view belongs to a different workspace you are part of. Would you like to switch to workspace: ${workspace.name} to view the asset?

@DonKoko DonKoko converted this from a draft issue Nov 15, 2024
@rockingrohit9639 rockingrohit9639 moved this from 🏗 In progress to 👀 In review in 🗺️ Shelf Roadmap Nov 30, 2024
@DonKoko DonKoko moved this from 👀 In review to ✅ Done in 🗺️ Shelf Roadmap Dec 5, 2024
@DonKoko DonKoko closed this as completed Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants