Feature/assets bulk actions #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockingrohit9639
requested a deployment
to
external
GitHub Actions
Waiting
rockingrohit9639
requested a deployment
to
external
GitHub Actions
Waiting
DonKoko
requested changes
Dec 3, 2024
There was a problem hiding this comment.
- Some server/client code mixup that needs resolving
- create booking modal is too skinny. Please make it the same as on the asset page
- When you try to add assets to existing booking that are already there, you get a nice message. That is fine for a singular asset but in this case you don't know which ones are added and which are not. Lets do a few things. 1) Lets first add a lit of the asset names of the ones that are already added. Then add a button saying something like: "Add only the rest of the assets". I can then figure out how to style it as I have no idea now.
- On successfull "add to existing" lets replace the content of the modal with the following.
Booking updated
The assets you selected have been added to the booking. Do you want to add more or view the booking
With 2 buttons: "Add more"(just closes modal) and "View booking" that sends you to the booking.
app/components/assets/assets-index/add-assets-to-existing-booking-dialog.tsx
Outdated
Show resolved
Hide resolved
rockingrohit9639
requested a deployment
to
external
GitHub Actions
Waiting
rockingrohit9639
requested a deployment
to
external
GitHub Actions
Waiting
…ser to add not-added assets in booking
rockingrohit9639
requested a deployment
to
external
GitHub Actions
Waiting
rockingrohit9639
requested a deployment
to
external
GitHub Actions
Waiting
DonKoko
requested changes
Dec 9, 2024
app/components/assets/assets-index/add-assets-to-existing-booking-dialog.tsx
Outdated
Show resolved
Hide resolved
app/components/assets/assets-index/add-assets-to-existing-booking-dialog.tsx
Outdated
Show resolved
Hide resolved
app/components/assets/assets-index/add-assets-to-existing-booking-dialog.tsx
Show resolved
Hide resolved
app/components/assets/assets-index/add-assets-to-existing-booking-dialog.tsx
Outdated
Show resolved
Hide resolved
rockingrohit9639
requested a deployment
to
external
GitHub Actions
Waiting
rockingrohit9639
requested a deployment
to
external
GitHub Actions
Waiting
DonKoko
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1451