Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various warnings in ShipPixelHit.cxx #401

Closed
olantwin opened this issue Jun 8, 2022 · 1 comment
Closed

Various warnings in ShipPixelHit.cxx #401

olantwin opened this issue Jun 8, 2022 · 1 comment
Labels

Comments

@olantwin
Copy link
Contributor

olantwin commented Jun 8, 2022

Not urgent, just to keep track of the warning until we fix it or charmdet is removed.

charmdet/ShipPixelHit.cxx: In constructor 'ShipPixelHit::ShipPixelHit(Int_t, Float_t)':
charmdet/ShipPixelHit.cxx:17:54: warning: declaration of 'detID' shadows a member of 'ShipPixelHit' [-Wshadow]
 ShipPixelHit::ShipPixelHit(Int_t detID,  Float_t digi) : ShipHit(detID, digi) {
                                                      ^
In file included from charmdet/ShipPixelHit.cxx:1:0:
charmdet/ShipPixelHit.h:37:12: note: shadowed declaration is here
    int32_t detID;
            ^~~~~
charmdet/ShipPixelHit.cxx: In member function 'void ShipPixelHit::GetPixelXYZ(TVector3&, int)':
charmdet/ShipPixelHit.cxx:49:58: warning: declaration of 'detID' shadows a member of 'ShipPixelHit' [-Wshadow]
 void ShipPixelHit::GetPixelXYZ(TVector3 &pixel, int detID) { //, std::shared_ptr <std::unordered_map<int, TVector3>> PixelPositionMap
                                                          ^
In file included from charmdet/ShipPixelHit.cxx:1:0:
charmdet/ShipPixelHit.h:37:12: note: shadowed declaration is here
    int32_t detID;
            ^~~~~
@fairlyons fairlyons added the bug label Sep 11, 2024
@olantwin
Copy link
Contributor Author

Charmdet was removed in e066f22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants