Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Theme dev hot reload does not update order in section groups #5007

Open
2 tasks done
frandiox opened this issue Dec 3, 2024 · 0 comments
Open
2 tasks done
Assignees
Labels
Area: @shopify/theme @shopify/theme package issues Type: Bug Something isn't working

Comments

@frandiox
Copy link
Contributor

frandiox commented Dec 3, 2024

Please confirm that you have:

  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

Theme

Expected behavior

Hot reload should sort DOM nodes accordingly in the browser when order changes in a section group.

Actual behavior

The sections are updated but they are not sorted properly.

Verbose output

Verbose output

Reproduction steps

  1. Run shopify theme dev
  2. Modify order in sections/header-group.json. For example, move header before announcement-bar and save the file.
  3. Check that the sections order in the browser have not been updated.

--

We are reloading each section separately but not the order. For reference, we should:

  1. Send order information from the CLI down to the browser via existing SSE (around here).
  2. After we have the updated sections in browser memory, use the order information to sort DOM nodes accordingly (around here).

Operating System

Mac OS Sequoia

Shopify CLI version (shopify --version)

3.70.0

Shell

No response

Node version (run node -v if you're not sure)

No response

What language and version are you using in your application?

No response

@frandiox frandiox added Area: @shopify/theme @shopify/theme package issues Type: Bug Something isn't working labels Dec 3, 2024
@frandiox frandiox self-assigned this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/theme @shopify/theme package issues Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant