Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Shopify CLI (v3.70.0) Bug: Settings Not Updating Without Multiple Saves #5037

Open
2 tasks done
shopify-development-code opened this issue Dec 5, 2024 · 6 comments
Assignees
Labels
Area: @shopify/theme @shopify/theme package issues Severity: 2 High Severity Type: Bug Something isn't working

Comments

@shopify-development-code

Please confirm that you have:

  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

Theme

Expected behavior

It should save and synced every time.

Actual behavior

We are encountering an issue where settings only appear after saving the file multiple times, which significantly disrupts our workflow. Each time we make changes, we have to repeatedly save the file to reflect the updates, which is both time-consuming and frustrating.

This issue persists across multiple development environments, and we are confident that it stems from the Shopify CLI. We are currently using the latest version (3.70.0) of the CLI, but the problem remains unresolved.

We would appreciate a resolution or guidance on addressing this issue to streamline our development process.

Repro steps: See attached screencast:
https://github.com/user-attachments/assets/e72d0a38-ee23-4987-a34f-cecc4400b707

See below screenshot, all times files are saved but not synced with editor:
Image

Here it is our environment for development:

[environments.dev]
store = "store-name"
password = "shptka_token"
theme-editor-sync = true

Verbose output

shopify theme dev -e dev
Files are not being saved and synced with editor on single save. But on terminal its showing files are synced correctly.

Reproduction steps

1.Repro steps: See attached screencast:
https://github.com/user-attachments/assets/e72d0a38-ee23-4987-a34f-cecc4400b707

Operating System

Windows 10, Windows 11

Shopify CLI version (shopify --version)

3.70.0

Shell

No response

Node version (run node -v if you're not sure)

v22.12.0

What language and version are you using in your application?

No response

@shopify-development-code shopify-development-code added the Type: Bug Something isn't working label Dec 5, 2024
@shopify-development-code shopify-development-code changed the title [Bug]: <Shopify CLI (v3.70.0) Bug: Settings Not Updating Without Multiple Saves> [Bug]: Shopify CLI (v3.70.0) Bug: Settings Not Updating Without Multiple Saves Dec 5, 2024
@frandiox frandiox added Area: @shopify/theme @shopify/theme package issues Severity: 2 High Severity labels Dec 10, 2024
@catlee
Copy link
Contributor

catlee commented Dec 10, 2024

I believe this should have been fixed by #5042

@frandiox
Copy link
Contributor

I believe this should have been fixed by #5042

That fix was released in 3.72.0 today. Can you try it @shopify-development-code ?

@shopify-development-code
Copy link
Author

@frandiox thanks for your response. We will check it and let you know.

@shopify-development-code
Copy link
Author

The issue still persists.

@kyrylo-soulandwolf
Copy link

@frandiox @catlee This is still a problem.
Only in my case the problem with hot-reloading a CSS file. It needs to be saved twice for the CSS to take effect.
I'm happy to open a new issue if it's not the same as this one.
I tested it on a fresh Dawn theme with CLI 3.73.2.

To reproduce:

  • Run shopify theme dev
  • Add anything to a CSS file
  • Save once

Result:

  • Console shows [HotReload] Event data: {type: 'css', key: 'assets/base.css'}
  • New CSS not applied

@frandiox
Copy link
Contributor

@kyrylo-soulandwolf This seems unrelated to the main issue. Can you check in the network tab if it is downloading the new file? When I try adding something like * { background-color: red !important; }, it updates the CSS in the browser 🤔 -- Please open an issue with your network tab findings if it doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/theme @shopify/theme package issues Severity: 2 High Severity Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants