Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use the discount sample app #524

Closed
RichardParnabyKing opened this issue Jul 2, 2024 · 2 comments
Closed

Can't use the discount sample app #524

RichardParnabyKing opened this issue Jul 2, 2024 · 2 comments

Comments

@RichardParnabyKing
Copy link

RichardParnabyKing commented Jul 2, 2024

I am cloning the discount-sample-app using the following command as per Shopify's documentation:

shopify app init --template https://github.com/Shopify/function-examples/sample-apps/discounts

But the command failed with the following errors:

Error coming from `npm install`

Command failed with exit code 1: npm install
npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: new-discount-app@undefined
npm error Found: @shopify/app-bridge-react@4.1.3
npm error node_modules/@shopify/app-bridge-react
npm error   @shopify/app-bridge-react@"^4.1.3" from the root project
npm error
npm error Could not resolve dependency:
npm error peer @shopify/app-bridge-react@"^3.7.7" from @shopify/discount-app-components@2.1.2
npm error node_modules/@shopify/discount-app-components
npm error   @shopify/discount-app-components@"2.1.2" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /Users/richardpk/.npm/_logs/2024-07-02T08_20_52_257Z-eresolve-report.txt
npm error A complete log of this run can be found in: /Users/richardpk/.npm/_logs/2024-07-02T08_20_52_257Z-debug-0.log
@Goondrious
Copy link

Probably covered in Shopify/discount-app-components#196

@mathiusj
Copy link
Contributor

fixed with: #547 for yarn
and #549 for npm

Just tested now and works! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants