Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples 1.1 and 1.6 #103

Closed
wants to merge 2 commits into from

Conversation

AlexPishchikov
Copy link

This PR fixes filling in examples 1.1 and 1.6.

In example 1.1 filling doesn't match with readme image.
In example 1.6 filling doesn't match with plot legend.

@SiegeLord
Copy link
Owner

This sounds more like Between option is broken. I'll take a look.

@AlexPishchikov
Copy link
Author

Maybe. You use closed gnuplot command for FillRegionType::Between, which fills polygon near line.
For filling between two lines you can use between. It works for me with gnuplot 6.0 but doesn't work properly with gnuplot 5.4.

So, i suggest to add new FillRegionType enum member which will use between command.

@SiegeLord
Copy link
Owner

Between should already have this behavior. The bug here is that the "closed" evidently at some point produced images like in the readme, but no longer does so. It appears that removing "closed" produces the correct behavior on 5.4 and 6.0. I don't know what "between" does, it is not documented.

So, what's needed here is to adjust the code to not send "closed" to gnuplot in any condition.

@SiegeLord
Copy link
Owner

This is now fixed by 5025f48.

Thanks for reporting this!

@SiegeLord SiegeLord closed this Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants