FilterParameter#hash_to_params: do not escape backslash. Fixes #74.

Sija · Aug 20, 2012 · dcaf227 · dcaf227
1 parent 59701f4
commit dcaf227
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/garb/filter_parameters.rb b/lib/garb/filter_parameters.rb
@@ -37,7 +37,7 @@ def hash_to_params(hsh)
       hsh.map do |k, v|
         next unless k.is_a?(SymbolOperatorMethods)
 
-        escaped_v = v.to_s.gsub(/([,;\\])/) { |c| '\\' + c }
+        escaped_v = v.to_s.gsub(/([,;])/) { |c| '\\' + c }
         "#{URI.encode(k.to_google_analytics, /[=<>]/)}#{CGI::escape(escaped_v)}"
       end.join('%3B') # Hash AND (no duplicate keys), escape char for ';' fixes oauth
     end

diff --git a/test/unit/garb/filter_parameters_test.rb b/test/unit/garb/filter_parameters_test.rb
@@ -35,10 +35,10 @@ class FilterParametersTest < MiniTest::Unit::TestCase
           assert_equal params, filters.to_params
         end
 
-        should "escape comma, semicolon, and backslash in values" do
+        should "escape comma, semicolon in values" do
           filters = FilterParameters.new({:url.eql => 'this;that,thing\other'})
 
-          params = {'filters' => 'ga:url%3D%3Dthis%5C%3Bthat%5C%2Cthing%5C%5Cother'}
+          params = {'filters' => 'ga:url%3D%3Dthis%5C%3Bthat%5C%2Cthing%5Cother'}
           assert_equal params, filters.to_params
         end