From ecaacea85efdab515367429113dbc48488c762fc Mon Sep 17 00:00:00 2001 From: Mathieu Kardous Date: Mon, 29 Apr 2024 19:20:02 +0000 Subject: [PATCH] Pull request #1796: Update matter support pointer to main Merge in WMN_TOOLS/matter from feature/update_matter_support to RC_2.3.0-1.3 Squashed commit of the following: commit 3e0dd4c3076d244545844a7d330e4ec31e16b02b Author: Mathieu Kardous Date: Mon Apr 29 12:33:53 2024 -0400 Update matter support pointer to main commit 5a170da155b4170c80d4d0ce2b1e8b254eeac7f2 Author: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com> Date: Wed Apr 17 18:25:20 2024 -0500 [Silabs] Change BLE address from random resolvable address to random static address (#33035) * Change BLE address from random resolvable address to static address * add comment * Replace lambda function with memcmp --- src/platform/silabs/efr32/BLEManagerImpl.cpp | 37 ++++++++++++++------ third_party/silabs/matter_support | 2 +- 2 files changed, 27 insertions(+), 12 deletions(-) diff --git a/src/platform/silabs/efr32/BLEManagerImpl.cpp b/src/platform/silabs/efr32/BLEManagerImpl.cpp index 1fd5f7720c7682..2478a078dbedcb 100644 --- a/src/platform/silabs/efr32/BLEManagerImpl.cpp +++ b/src/platform/silabs/efr32/BLEManagerImpl.cpp @@ -40,6 +40,8 @@ extern "C" { #include "sl_bt_stack_init.h" #include "timers.h" #include +#include +#include #include #include #include @@ -109,17 +111,16 @@ const ChipBleUUID ChipUUID_CHIPoBLEChar_RX = { { 0x18, 0xEE, 0x2E, 0xF5, 0x26, 0 const ChipBleUUID ChipUUID_CHIPoBLEChar_TX = { { 0x18, 0xEE, 0x2E, 0xF5, 0x26, 0x3D, 0x45, 0x59, 0x95, 0x9F, 0x4F, 0x9C, 0x42, 0x9F, 0x9D, 0x12 } }; +bd_addr randomizedAddr = { 0 }; + } // namespace BLEManagerImpl BLEManagerImpl::sInstance; CHIP_ERROR BLEManagerImpl::_Init() { - CHIP_ERROR err; - // Initialize the CHIP BleLayer. - err = BleLayer::Init(this, this, &DeviceLayer::SystemLayer()); - SuccessOrExit(err); + ReturnErrorOnFailure(BleLayer::Init(this, this, &DeviceLayer::SystemLayer())); memset(mBleConnections, 0, sizeof(mBleConnections)); memset(mIndConfId, kUnusedIndex, sizeof(mIndConfId)); @@ -135,10 +136,23 @@ CHIP_ERROR BLEManagerImpl::_Init() mFlags.ClearAll().Set(Flags::kAdvertisingEnabled, CHIP_DEVICE_CONFIG_CHIPOBLE_ENABLE_ADVERTISING_AUTOSTART); mFlags.Set(Flags::kFastAdvertisingEnabled, true); - PlatformMgr().ScheduleWork(DriveBLEState, 0); -exit: - return err; + // Check that an address was not already configured at boot. + // This covers the init-shutdown-init case to comply with the BLE address change at boot only requirement + bd_addr temp = { 0 }; + if (memcmp(&randomizedAddr, &temp, sizeof(bd_addr)) == 0) + { + // Since a random address is not configured, configure one + uint64_t random = Crypto::GetRandU64(); + // Copy random value to address. We don't care of the ordering since it's a random value. + memcpy(&randomizedAddr, &random, sizeof(randomizedAddr)); + + // Set two MSBs to 11 to properly the address - BLE Static Device Address requirement + randomizedAddr.addr[5] |= 0xC0; + } + + PlatformMgr().ScheduleWork(DriveBLEState, 0); + return CHIP_NO_ERROR; } uint16_t BLEManagerImpl::_NumConnections(void) @@ -487,14 +501,13 @@ CHIP_ERROR BLEManagerImpl::ConfigureAdvertisingData(void) ChipLogError(DeviceLayer, "sl_bt_advertiser_create_set() failed: %s", ErrorStr(err)); }); - bd_addr randomizedAddr = {}; - ret = sl_bt_advertiser_set_random_address(advertising_set_handle, sl_bt_gap_random_resolvable_address, randomizedAddr, - &randomizedAddr); + ret = + sl_bt_advertiser_set_random_address(advertising_set_handle, sl_bt_gap_static_address, randomizedAddr, &randomizedAddr); VerifyOrExit(ret == SL_STATUS_OK, { err = MapBLEError(ret); ChipLogError(DeviceLayer, "sl_bt_advertiser_set_random_address() failed: %s", ErrorStr(err)); }); - ChipLogDetail(DeviceLayer, "BLE Resolvable private random address %02X:%02X:%02X:%02X:%02X:%02X", randomizedAddr.addr[5], + ChipLogDetail(DeviceLayer, "BLE Static Device Address %02X:%02X:%02X:%02X:%02X:%02X", randomizedAddr.addr[5], randomizedAddr.addr[4], randomizedAddr.addr[3], randomizedAddr.addr[2], randomizedAddr.addr[1], randomizedAddr.addr[0]); } @@ -628,6 +641,8 @@ CHIP_ERROR BLEManagerImpl::StopAdvertising(void) mFlags.Set(Flags::kFastAdvertisingEnabled, true); ret = sl_bt_advertiser_stop(advertising_set_handle); + sl_bt_advertiser_clear_random_address(advertising_set_handle); + sl_bt_advertiser_delete_set(advertising_set_handle); advertising_set_handle = 0xff; err = MapBLEError(ret); diff --git a/third_party/silabs/matter_support b/third_party/silabs/matter_support index afcecbb2bdc31f..56d4d4ec0dea03 160000 --- a/third_party/silabs/matter_support +++ b/third_party/silabs/matter_support @@ -1 +1 @@ -Subproject commit afcecbb2bdc31ffed4a95b442ebf4e046d473351 +Subproject commit 56d4d4ec0dea032302f52632c15d4d7813f8e9f5