Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider talking to Pinner #32

Open
MSevey opened this issue Aug 9, 2022 · 0 comments
Open

Consider talking to Pinner #32

MSevey opened this issue Aug 9, 2022 · 0 comments

Comments

@MSevey
Copy link
Contributor

MSevey commented Aug 9, 2022

It's sometimes possible for nginx to fail to call accounts on upload. See https://discord.com/channels/542938080349519882/542939142183452672/989840713028096030. This means that we're allowing the upload of skyfiles that are not scanned by malware-scanner and won't be blocked if they contain malware.

On the other hand we have Pinner who's running daily sweeps of what's actually being pinned by skyd on all servers. If we allow Pinner to expose a list of all skylinks (limited by timestamp, counts, etc.) then it might be useful to have malware-scanner fetch that list incrementally and add any new skylinks it encounters to its scan queue.

This is just an idea at this point and the only immediate action item is to have a chat about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant