New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated Ginkgo functionality #56

Open

maruina opened this issue Apr 13, 2021 · 0 comments

Assignees

Labels

bug

Contributor

maruina commented Apr 13, 2021

We use a deprecated Ginkgo functionality. The test output is https://github.com/Skyscanner/argocd-progressive-rollout/pull/53/checks?check_run_id=2331406128#step:7:246

There is a recommended migration path: https://github.com/onsi/ginkgo/blob/v2/docs/MIGRATING_TO_V2.md#removed-async-testing

maruina added the bug label

maruina self-assigned this

maruina added this to the Milestone 2 milestone

maruina mentioned this issue

Fix ginkgo async testing #57

Closed

maruina removed this from the Milestone 2 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment