Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypedRemote: Fix OnClientEvent #201

Closed
wants to merge 0 commits into from

Conversation

Ultrasonic1209
Copy link

At the moment, OnClientEvent connections to valid handlers get warnings as the typechecker erroneously asserts that OnClientEvent handlers must have a Player instance as their first parameter.

Changes:

  1. The Signal type's methods now use Signal for its methods' self parameters, instead of PlayerSignal.
  2. The Event type's OnServerEvent and OnClientEvent typings have been swapped to reflect that OnClientEvent handlers do not receive any player object, but OnServerEvent handlers do, hence why OnServerEvent handlers should be PlayerSignals instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant