Corrects Signal + Event.OnClientEvent: PlayerSignal + Event.OnServerEvent: Signal type errors #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses the following type error on TypedRemoteEvent:
TypeError: Type
'Signal<number>'
could not be converted into
'PlayerSignal<number>'
This reverts commit 2f55e49.
Addresses OnClientEvent type error where OnClientEvent was specified to be a PlayerSignal type, accepting a player argument as the first argument Also addresses OnServerEvent type error where OnServerEvent was specified to be a Signal type, not accepting a player argument as the first argument. Also corrects the type definition for Signal, which was specifying that self was a PlayerSignal instead of a Signal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Corrects
Signaltype definitionSignalreferred to itsselfasPlayerSignalinstead ofSignal.self: PlayerSignalhas been changed toself: Signalto correct type errors2. Corrects
Event.OnClientEventtype fromPlayerSignaltoSignal.OnClientEvent does not carry a
Playeras its first argument and therefore needs to useSignalrather thanPlayerSignal3. Corrects
Event.OnServerEventtype fromSignaltoPlayerSignal.OnServerEvent requires a
Playeras its first argument and therefore needs to usePlayerSignalrather thanSignalIt is entirely possible that these two simply got mixed up: