Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book Binder reverts the enchantment level to maximal on the config #3247

Closed
4 tasks done
variananora opened this issue Sep 12, 2021 · 3 comments · Fixed by #3925
Closed
4 tasks done

Book Binder reverts the enchantment level to maximal on the config #3247

variananora opened this issue Sep 12, 2021 · 3 comments · Fixed by #3925
Labels
🐞 Bug Report A bug that needs to be fixed. 🧨 Confirmed Bug This bug has been confirmed by our team. ✔ Resolved This Issue has been resolved.

Comments

@variananora
Copy link
Member

❗ Checklist

  • I am using the official english version of Slimefun and did not modify the jar.
  • I am using an up to date "DEV" (not "RC") version of Slimefun.
  • I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
  • I searched for similar open issues and could not find an existing bug report on this.

📍 Description

Book Binder reverts the enchantment level to maximal on the config if your enchanted book exceeds it.

https://discord.com/channels/565557184348422174/565569972697301020/886602140280324136

📑 Reproduction Steps

  1. Set bypass-vanilla-max-level: false for vanilla cap or custom-max-level: 10 and has-custom-max-level: true
  2. Use book binder
  3. Put an enchantment that exceeds vanilla limit or maximum level cap on config
  4. Wait it process
  5. It will revert the enchantment to maximum configured level (vanilla/config).

💡 Expected Behavior

Book binder should not take the items and revert the enchantment to maximum configured level (vanilla/config). It should just not work.

📷 Screenshots / Videos

https://youtu.be/lW0-6tL46SM

📜 Server Log

No response

📂 /error-reports/ folder

No response

💻 Server Software

Paper

🎮 Minecraft Version

1.17.x

⭐ Slimefun version

> sf versions
[21:07:57 INFO]: This Server uses the following setup of Slimefun:
Paper git-Paper-259 (MC: 1.17.1)
Slimefun DEV - 968 (git 79c6c139)
Metrics-Module #28
Java 16

No Addons installed
> pl
[21:07:57 INFO]: Plugins (3): Slimefun, Vault, VoidGen
> ver
[21:07:58 INFO]: Checking version, please wait...
[21:08:00 INFO]: This server is running Paper version git-Paper-259 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: 810d200)
You are running the latest version
Previous version: git-Paper-250 (MC: 1.17.1)

🧭 Other plugins

No response

@variananora variananora added 🐞 Bug Report A bug that needs to be fixed. 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. labels Sep 12, 2021
@WalshyDev WalshyDev added the Hacktoberfest This Issue or Pull Request is part of the Hacktoberfest! label Sep 23, 2021
@TheBusyBiscuit TheBusyBiscuit removed the Hacktoberfest This Issue or Pull Request is part of the Hacktoberfest! label Nov 30, 2021
@JustAHuman-xD
Copy link
Contributor

Is this fixed in the lastest build with the book binder changes?

@Boomer-1
Copy link

I just tested it and it is still an issue. I set bypass vanilla to false, put in an unbreaking X and an unbreaking 3 and got an unbreaking 3 out.

@Boomer-1
Copy link

Alessio did a similar fix to this issue with the auto enchanters

@variananora variananora added 🧨 Confirmed Bug This bug has been confirmed by our team. and removed 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. labels Jul 4, 2023
@variananora variananora added the ✔ Resolved This Issue has been resolved. label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug Report A bug that needs to be fixed. 🧨 Confirmed Bug This bug has been confirmed by our team. ✔ Resolved This Issue has been resolved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants