Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move auto saves from main thread to off thread #4118

Closed
4 tasks done
Boomer-1 opened this issue Feb 4, 2024 · 0 comments · Fixed by #4119
Closed
4 tasks done

move auto saves from main thread to off thread #4118

Boomer-1 opened this issue Feb 4, 2024 · 0 comments · Fixed by #4119
Labels
🐞 Bug Report A bug that needs to be fixed. ✔ Resolved This Issue has been resolved.

Comments

@Boomer-1
Copy link

Boomer-1 commented Feb 4, 2024

❗ Checklist

  • I am using the official english version of Slimefun and did not modify the jar.
  • I am using an up to date "DEV" (not "RC") version of Slimefun.
  • I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
  • I searched for similar open issues and could not find an existing bug report on this.

📍 Description

See the discord thread below

https://discord.com/channels/565557184348422174/565569196218384385/1203819747687268403

and walshy's notes

https://discord.com/channels/565557184348422174/565569196218384385/1203820974470860893

📑 Reproduction Steps

review the spark report linked above

💡 Expected Behavior

moving save to off the main thread to reduce lag when saving

📷 Screenshots / Videos

No response

📜 Server Log

none

📂 /error-reports/ folder

none

💻 Server Software

Paper

🎮 Minecraft Version

1.20.x

⭐ Slimefun version

1133

🧭 Other plugins

No response
@Boomer-1 Boomer-1 added 🐞 Bug Report A bug that needs to be fixed. 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. labels Feb 4, 2024
@WalshyDev WalshyDev mentioned this issue Feb 4, 2024
Merged
7 tasks
@J3fftw1 J3fftw1 changed the title Walshy - move auto saves from main thread to off thread move auto saves from main thread to off thread Feb 5, 2024
@variananora variananora added ✔ Resolved This Issue has been resolved. and removed 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 Bug Report A bug that needs to be fixed. ✔ Resolved This Issue has been resolved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move PlayerProfile saving off the main thread Slimefun/Slimefun4
2 participants
@variananora @Boomer-1